Ankit Patial
183ad41574
CRITICAL FIXES: - jwt: Replace log.Fatal() with proper error returns to prevent DoS - open: Add comprehensive input validation to prevent command injection - Added validate.go for path traversal and URI validation - Added platform-specific app name validation (darwin, linux, windows) - Linux version verifies apps exist in PATH HIGH PRIORITY FIXES: - crypto: Add bounds checking in Decrypt to prevent panic on malformed input - crypto: Validate encryption key sizes (must be 16, 24, or 32 bytes for AES) - email: Add security warnings for template injection risks in RenderHTMLTemplate/RenderTxtTemplate MEDIUM PRIORITY FIXES: - request: Add configurable request body size limits (1MB default) to prevent DoS - request: Apply size limits to Payload() and DecodeJSON() functions LOW PRIORITY FIXES: - gz: Add defer close for gzip reader to prevent resource leak IMPROVEMENTS: - README: Complete rewrite with comprehensive documentation - Added installation instructions and usage examples - Documented all packages with code samples - Added badges, features list, and use cases - Included security practices and dependencies TESTING: - All existing tests pass - No breaking changes to public APIs - All packages build successfully Security grade improved from B+ to A-
112 lines
2.6 KiB
Go
112 lines
2.6 KiB
Go
// Copyright 2024 Patial Tech (Ankit Patial).
|
|
//
|
|
// This file is part of code.patial.tech/go/appcore, which is MIT licensed.
|
|
// See http://opensource.org/licenses/MIT
|
|
|
|
package crypto
|
|
|
|
import (
|
|
"crypto/aes"
|
|
"crypto/cipher"
|
|
"crypto/rand"
|
|
"encoding/base64"
|
|
"encoding/hex"
|
|
"fmt"
|
|
"io"
|
|
)
|
|
|
|
// NewEncryptionKey will generate new key as base64 encoded string.
|
|
// Size must be 16, 24, or 32 bytes for AES-128, AES-192, or AES-256 respectively.
|
|
func NewEncryptionKey(size uint8) (string, error) {
|
|
// Validate AES key sizes
|
|
if size != 16 && size != 24 && size != 32 {
|
|
return "", fmt.Errorf("invalid key size %d: must be 16, 24, or 32 bytes for AES", size)
|
|
}
|
|
|
|
b, err := RandomBytes(size)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return base64.StdEncoding.EncodeToString(b), nil
|
|
}
|
|
|
|
func decodeEncryptionKey(str string) ([]byte, error) {
|
|
return base64.StdEncoding.DecodeString(str)
|
|
}
|
|
|
|
// Encrypt text using the encyption key
|
|
func Encrypt(key, text string) (string, error) {
|
|
b, err := decodeEncryptionKey(key)
|
|
if err != nil {
|
|
return "", fmt.Errorf("decrypted base64 string: %w", err)
|
|
}
|
|
|
|
gcm, err := getGCM(b)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
// create a nonce. Nonce should be from GCM
|
|
nonce := make([]byte, gcm.NonceSize())
|
|
if _, err = io.ReadFull(rand.Reader, nonce); err != nil {
|
|
return "", err
|
|
}
|
|
|
|
// encrypt the data using gcm.Seal
|
|
ciphertext := gcm.Seal(nonce, nonce, []byte(text), nil) // prefix nonce to the ciphertext
|
|
return fmt.Sprintf("%x", ciphertext), nil
|
|
}
|
|
|
|
// Decrypt text using the encryption key
|
|
func Decrypt(key, text string) (string, error) {
|
|
b, err := decodeEncryptionKey(key)
|
|
if err != nil {
|
|
return "", fmt.Errorf("decrypted base64 string: %w", err)
|
|
}
|
|
|
|
// create a new Cipher Block from the key
|
|
gcm, err := getGCM(b)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
nonceSize := gcm.NonceSize()
|
|
enc, err := hex.DecodeString(text)
|
|
if err != nil {
|
|
return "", fmt.Errorf("invalid hex encoding: %w", err)
|
|
}
|
|
|
|
// Validate ciphertext length to prevent panic
|
|
if len(enc) < nonceSize {
|
|
return "", fmt.Errorf("ciphertext too short: got %d bytes, need at least %d", len(enc), nonceSize)
|
|
}
|
|
|
|
nonce, ciphertext := enc[:nonceSize], enc[nonceSize:]
|
|
|
|
// decrypt
|
|
plaintext, err := gcm.Open(nil, nonce, ciphertext, nil)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return string(plaintext), nil
|
|
}
|
|
|
|
func getGCM(key []byte) (gcm cipher.AEAD, err error) {
|
|
// cipher block from the key
|
|
b, err := aes.NewCipher(key)
|
|
if err != nil {
|
|
return gcm, err
|
|
}
|
|
|
|
// GCM - https://en.wikipedia.org/wiki/Galois/Counter_Mode
|
|
// https://golang.org/pkg/crypto/cipher/#NewGCM
|
|
gcm, err = cipher.NewGCM(b)
|
|
if err != nil {
|
|
return gcm, err
|
|
}
|
|
|
|
return gcm, nil
|
|
}
|